Skip to content

Conversation

helinwang
Copy link
Contributor

Previously feature importance is added with a params parameter, the
user has to set params = {"feature_importance": "true"}. This PR
simplifies the logic, the user just have to pass feature_importance =
True.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 15, 2019
@helinwang helinwang requested a review from sirtorry November 15, 2019 23:41
Previously feature importance is added with a params parameter, the
user has to set params = {"feature_importance": "true"}. This PR
simplifies the logic, the user just have to pass feature_importance =
True.
Copy link
Contributor

@sirtorry sirtorry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@busunkim96 busunkim96 merged commit 8d745d0 into googleapis:master Nov 16, 2019
parthea pushed a commit that referenced this pull request Oct 21, 2023
Previously feature importance is added with a params parameter, the
user has to set params = {"feature_importance": "true"}. This PR
simplifies the logic, the user just have to pass feature_importance =
True.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants