feat: Add Postgres Reader #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I tested the failing lint and tests in local, after merging with PR#52 and they are passing, so seems like the failure is because that PR isn't yet merged to main.
Changing base branch in GH UI didn't fix the tests!
Test log
Tests pass when run together with async version of code
(venv311) (base) ➜ llama-index-cloud-sql-pg-python git:(add-sync-reader) ✗ PYTHONPATH=src pytest -v -k reader
======================================================================================================================= test session starts =======================================================================================================================
platform linux -- Python 3.11.9, pytest-8.3.4, pluggy-1.5.0 -- /usr/local/google/home/vishwarajanand/github/llama-index-cloud-sql-pg-python/venv311/bin/python
cachedir: .pytest_cache
rootdir: /usr/local/google/home/vishwarajanand/github/llama-index-cloud-sql-pg-python
configfile: pyproject.toml
plugins: anyio-4.8.0, asyncio-0.25.2
asyncio: mode=Mode.STRICT, asyncio_default_fixture_loop_scope=class
collected 221 items / 200 deselected / 21 selected
tests/test_async_reader.py::TestAsyncPostgresReader::test_create_reader_with_invalid_parameters PASSED [ 4%]
tests/test_async_reader.py::TestAsyncPostgresReader::test_load_from_query_default PASSED [ 9%]
tests/test_async_reader.py::TestAsyncPostgresReader::test_load_from_query_customized_content_customized_metadata PASSED [ 14%]
tests/test_async_reader.py::TestAsyncPostgresReader::test_load_from_query_customized_content_default_metadata PASSED [ 19%]
tests/test_async_reader.py::TestAsyncPostgresReader::test_load_from_query_with_json PASSED [ 23%]
tests/test_async_reader.py::TestAsyncPostgresReader::test_load_from_query_customized_content_default_metadata_custom_formatter PASSED [ 28%]
tests/test_async_reader.py::TestAsyncPostgresReader::test_load_from_query_customized_content_default_metadata_custom_page_content_format PASSED [ 33%]
tests/test_reader.py::TestPostgresReaderAsync::test_create_reader_with_invalid_parameters PASSED [ 38%]
tests/test_reader.py::TestPostgresReaderAsync::test_load_from_query_default PASSED [ 42%]
tests/test_reader.py::TestPostgresReaderAsync::test_load_from_query_customized_content_customized_metadata PASSED [ 47%]
tests/test_reader.py::TestPostgresReaderAsync::test_load_from_query_customized_content_default_metadata PASSED [ 52%]
tests/test_reader.py::TestPostgresReaderAsync::test_load_from_query_with_json PASSED [ 57%]
tests/test_reader.py::TestPostgresReaderAsync::test_load_from_query_customized_content_default_metadata_custom_formatter PASSED [ 61%]
tests/test_reader.py::TestPostgresReaderAsync::test_load_from_query_customized_content_default_metadata_custom_page_content_format PASSED [ 66%]
tests/test_reader.py::TestPostgresReaderSync::test_create_reader_with_invalid_parameters PASSED [ 71%]
tests/test_reader.py::TestPostgresReaderSync::test_load_from_query_default PASSED [ 76%]
tests/test_reader.py::TestPostgresReaderSync::test_load_from_query_customized_content_customized_metadata PASSED [ 80%]
tests/test_reader.py::TestPostgresReaderSync::test_load_from_query_customized_content_default_metadata PASSED [ 85%]
tests/test_reader.py::TestPostgresReaderSync::test_load_from_query_with_json PASSED [ 90%]
tests/test_reader.py::TestPostgresReaderSync::test_load_from_query_customized_content_default_metadata_custom_formatter PASSED [ 95%]
tests/test_reader.py::TestPostgresReaderSync::test_load_from_query_customized_content_default_metadata_custom_page_content_format PASSED [100%]
========================================================================================================== 21 passed, 200 deselected in 94.28s (0:01:34) ==========================================================================================================
(venv311) (base) ➜ llama-index-cloud-sql-pg-python git:(add-sync-reader) ✗
|
By mistake, I pushed the merged branch with PR#52. Either we can merge that PR first, and rebase to see async interfaces go away. |
fb0cc36 to
e5334ab
Compare
averikitsch
reviewed
Jan 27, 2025
averikitsch
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add Postgres Reader