-
Notifications
You must be signed in to change notification settings - Fork 3
chore: add tests for sync methods in async interfaces #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why did the test pass? Is our codecoverage setup different than langchain that errors out? |
@averikitsch the tests indeed passed now despite having coverage<90. Example, recent cloud build is green when the logs suggested:
My hypothesis is that this happens due to rounding issue with pytest, (89.89 ==> 90). I made a github PR to assert that our code coverage configs are indeed correct and tests fail if coverage drops below the 89% mark, and they do fail when coverage is 88.76%. Ref: #63 |
Probably the default value (zero) of precision in pytest-cov plugin is to blame and a solution could be to set But its an overkill for just 1% coverage. |
Thank you! |
In an unrelated PR #57, test coverage dropped to <90, so adding some tests to bump it up.
Also contains, nits (improper spacing) on exception messages for sync methods of async interfaces.