fix: mitigate collisions in field names #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ece257c to
3ea8150
Compare
Codecov Report
@@ Coverage Diff @@
## main #295 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 22
Lines ? 986
Branches ? 220
========================================
Hits ? 986
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
1 task
7a347b1 to
4de2462
Compare
vam-google
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Underscores may be appended to field names that collide with python or proto-plus keywords. In case a key only exists with a
_suffix, coerce the key to include the_suffix. It's not possible to natively define the same field with a trailing underscore in protobuf. See related issue googleapis/python-api-core#227