fix: construct messages with nested duration in protobuf 5.28+ #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
81cd01d to
d851c1c
Compare
vchudnov-g
approved these changes
Jan 21, 2025
| @@ -241,6 +241,26 @@ class Foo(proto.Message): | |||
| assert Foo.pb(foo).ttl.seconds == 120 | |||
|
|
|||
|
|
|||
| def test_duration_write_string_nested(): | |||
There was a problem hiding this comment.
nit: for clarity, I suggest:
s/another_field/foo_field/g
s/some_field/bar_field/g
Co-authored-by: Victor Chudnovsky <vchudnov@google.com>
Co-authored-by: Victor Chudnovsky <vchudnov@google.com>
This was referenced Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is similar to #479 where message construction fails when a specific type, in this case
google.protobuf.duration_pb2.Duration, is nested.Fixes #518
Fixes googleapis/google-cloud-python#13350