Skip to content
This repository was archived by the owner on Mar 15, 2025. It is now read-only.

chore: use templated noxfile.py #47

Merged
merged 3 commits into from
Jun 22, 2021
Merged

chore: use templated noxfile.py #47

merged 3 commits into from
Jun 22, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jun 20, 2021

No description provided.

@parthea parthea requested a review from a team as a code owner June 20, 2021 14:46
@product-auto-label product-auto-label bot added the api: accesscontextmanager Issues related to the googleapis/python-access-context-manager API. label Jun 20, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2021
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 20, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 20, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 20, 2021
@parthea parthea force-pushed the use-templated-noxfile branch from 4fe6b1e to 7c0211a Compare June 20, 2021 15:51
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 20, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 20, 2021
@parthea parthea force-pushed the use-templated-noxfile branch from 9d1750a to 357593c Compare June 22, 2021 02:19
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2021
@parthea parthea force-pushed the use-templated-noxfile branch from 63fd4c9 to 20c1a8f Compare June 22, 2021 08:03
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2021
@parthea parthea force-pushed the use-templated-noxfile branch from 20c1a8f to 9d3cf90 Compare June 22, 2021 13:19
@parthea parthea force-pushed the use-templated-noxfile branch from 9d3cf90 to eed6f49 Compare June 22, 2021 13:20
@parthea parthea mentioned this pull request Jun 22, 2021
Merged
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2021
busunkim96
busunkim96 previously approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it looks like there's an extra file called tests/.gitkeep, please delete that before merging.

@parthea
Copy link
Contributor Author

parthea commented Jun 22, 2021

@busunkim96 The .gitkeep file is only to check in an empty tests directory into git. The templated noxfile.py here expects a test folder. Otherwise, I would need to add more code in owlbot.py to exclude the sessions that check for tests.

@parthea parthea requested a review from busunkim96 June 22, 2021 15:13
@parthea
Copy link
Contributor Author

parthea commented Jun 22, 2021 •
edited
Loading

@busunkim96 Please could I have another review based on my last comment?

@parthea parthea dismissed busunkim96’s stale review June 22, 2021 15:39

@busunkim96 Please could I have another review based on my last comment?

busunkim96
busunkim96 approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah makes sense. Thanks for the explanation!

@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Jun 22, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit c340d13 into googleapis:master Jun 22, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees

@busunkim96 busunkim96

Labels
api: accesscontextmanager Issues related to the googleapis/python-access-context-manager API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parthea @busunkim96 @yoshi-kokoro