Skip to content

Retry.with_delay sets multiplier even when it's None #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
quentin-sommer opened this issue Mar 30, 2021 · 1 comment
Closed

Retry.with_delay sets multiplier even when it's None #163

quentin-sommer opened this issue Mar 30, 2021 · 1 comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@quentin-sommer
Copy link
Contributor

quentin-sommer commented Mar 30, 2021 •
edited
Loading

Steps to reproduce

from google.api_core import retry

retry.Retry(predicate=...).with_delay(initial=0.5, maximum=5 * 60)

retry._multiplier will be set to None because with_delay sets it when maximum is given

PR: #164
@quentin-sommer quentin-sommer mentioned this issue Mar 30, 2021
Merged
@busunkim96 busunkim96 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 31, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 31, 2021
@quentin-sommer
Fix retry.with_delay multiplier parameter handling (#164)
1647f07 
Issue: #163
@quentin-sommer
Copy link
Contributor Author

Closed in #164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@busunkim96 @quentin-sommer