Skip to content

Use unittest.mock if it is available #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
major opened this issue Jun 15, 2021 · 1 comment
Closed

Use unittest.mock if it is available #207

major opened this issue Jun 15, 2021 · 1 comment

Comments

@major
Copy link

major commented Jun 15, 2021

Environment details

  • OS type and version: Fedora 34
  • Python version: Python 3.9.5
  • pip version: pip 21.1.2
  • google-api-core version: 1.3.0

Using the mock module for recent versions of Python is deprecated. If the built-in unittest.mock is available for testing, that should be used instead.
@major major mentioned this issue Jun 15, 2021
Closed
4 tasks
major added a commit to major/python-api-core that referenced this issue Jun 15, 2021
@major
Bug: Use unittest.mock if it is available
afc2462 
The python mock module is deprecated in recent Python versions. If
unittest.mock is available in the system's python, use that instead.

Fixes: googleapis#207

Signed-off-by: Major Hayden <major@mhtx.net>
@tseaver
Copy link
Contributor

tseaver commented Jun 15, 2021

Superseded by #210.

@tseaver tseaver closed this as completed Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use unittest.mock if it is available major/python-api-core
2 participants
@major @tseaver