Skip to content

Release 2.3.1 wheel includes broken code #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rhys-adams opened this issue Dec 16, 2021 · 2 comments
Closed

Release 2.3.1 wheel includes broken code #323

rhys-adams opened this issue Dec 16, 2021 · 2 comments
Labels
priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@rhys-adams
Copy link

The google_api_core-2.3.1-py2.py3-none-any.whl file from PyPI includes what appears to be a patch failure:

    13059  12-15-2021 16:16   google/api_core/retry_BACKUP_3939795.py
    12781  12-15-2021 16:16   google/api_core/retry_BASE_3939795.py
    12770  12-15-2021 16:16   google/api_core/retry_LOCAL_3939795.py
    12786  12-15-2021 16:16   google/api_core/retry_REMOTE_3939795.py

This is causing my Cloud Function build to fail (log below).

Environment details

  • OS type and version: Google Cloud Build environment and local Linux (NixOS 21.05)
  • Python version: 3.9.9
  • pip version: 21.2.4
  • google-api-core version: 2.3.1

Steps to reproduce

  1. Try to deploy a Cloud Function with google-api-core in the dependency tree, eg. via a dependency on google-cloud-aiplatform in requirements.txt.
  2. Look Cloud Logs and see build failure.

Cloud Build log

Build failed: *** Error compiling './pip/google/api_core/retry_BACKUP_3939795.py'...
Sorry: IndentationError: expected an indented block (retry_BACKUP_3939795.py, line 204)

Current workaround is adding google-api-core==2.3.0 to requirements.txt.

Ref #319.
@parthea parthea mentioned this issue Dec 16, 2021
Merged
@parthea
Copy link
Collaborator

parthea commented Dec 16, 2021 •
edited
Loading

Hi @rhys-adams,

Thank you for reporting this issue. I'm sorry to write that I published a bad release. Although I am able to install the wheels locally using pip install *.whl, I can see from the logs that you shared that the wheels is broken. I've published a new version 2.3.2. Please let me know if this fixes the issue!

@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p0 Highest priority. Critical issue. P0 implies highest priority. labels Dec 16, 2021
@parthea
Copy link
Collaborator

parthea commented Dec 16, 2021

I'm going to mark this issue as resolved as I've yanked the 2.3.1 release from PyPI. See the release history here.

Version 2.3.2 is available here.

Please re-open this issue if you're still having trouble with 2.3.2.

@parthea parthea closed this as completed Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parthea @rhys-adams