Skip to content

fix: handle bare 'grpc.Call' in 'from_grpc_error' #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 3, 2021
Merged

fix: handle bare 'grpc.Call' in 'from_grpc_error' #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3b00ec7
fix: handle bare 'grpc.Call' in 'from_grpc_error'
tseaver Oct 27, 2021
d6820df
Merge branch 'main' into 297-handle-bare-rpc-call
tseaver Oct 28, 2021
0885647
tests: add assertion for 'exception.details'
tseaver Nov 2, 2021
af5707a
Merge branch 'main' into 297-handle-bare-rpc-call
tseaver Nov 2, 2021
274ddbb
Merge branch '297-handle-bare-rpc-call' of github.com:googleapis/pyth…
tseaver Nov 2, 2021
754ca0b
Merge branch 'main' into 297-handle-bare-rpc-call
tseaver Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion google/api_core/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,9 +487,14 @@ def _is_informative_grpc_error(rpc_exc):


def _parse_grpc_error_details(rpc_exc):
status = rpc_status.from_call(rpc_exc)
try:
status = rpc_status.from_call(rpc_exc)
except NotImplementedError: # workaround
return []

if not status:
return []

possible_errors = [
error_details_pb2.BadRequest,
error_details_pb2.PreconditionFailure,
Expand Down
28 changes: 28 additions & 0 deletions tests/unit/test_exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,34 @@ def test_from_grpc_error_non_call():
assert exception.response == error


@pytest.mark.skipif(grpc is None, reason="No grpc")
def test_from_grpc_error_bare_call():
message = "Testing"

class TestingError(grpc.Call, grpc.RpcError):
def __init__(self, exception):
self.exception = exception

def code(self):
return self.exception.grpc_status_code

def details(self):
return message

nested_message = "message"
error = TestingError(exceptions.GoogleAPICallError(nested_message))

exception = exceptions.from_grpc_error(error)

assert isinstance(exception, exceptions.GoogleAPICallError)
assert exception.code is None
assert exception.grpc_status_code is None
assert exception.message == message
assert exception.errors == [error]
assert exception.response == error
assert exception.details == []


def create_bad_request_details():
bad_request_details = error_details_pb2.BadRequest()
field_violation = bad_request_details.field_violations.add()
Expand Down