Skip to content

feat: add universe_domain argument to ClientOptions #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 20, 2023
Merged

feat: add universe_domain argument to ClientOptions #546

merged 10 commits into from
Nov 20, 2023

Conversation

ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Nov 6, 2023 •
edited by parthea
Loading

Fixes #547 🦕

BEGIN_COMMIT_OVERRIDE
feat: add universe_domain argument to ClientOptions
END_COMMIT_OVERRIDE

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 6, 2023
@ohmayr ohmayr marked this pull request as ready for review November 20, 2023 16:37
@ohmayr ohmayr requested review from a team as code owners November 20, 2023 16:37
parthea
parthea reviewed Nov 20, 2023
View reviewed changes
@ohmayr ohmayr force-pushed the feature/add-universe-domain-option-for-tpc branch from 6659f20 to 193ebe0 Compare November 20, 2023 18:04
@ohmayr ohmayr force-pushed the feature/add-universe-domain-option-for-tpc branch from bf0d17a to bdafd5f Compare November 20, 2023 18:24
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Nov 20, 2023
arithmetic1728
arithmetic1728 reviewed Nov 20, 2023
View reviewed changes
parthea
parthea reviewed Nov 20, 2023
View reviewed changes
ohmayr and others added 2 commits November 20, 2023 13:54
@ohmayr @parthea
Update google/api_core/client_options.py
5862624 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@ohmayr
Update client_options.py
bd83a05
@parthea parthea changed the title feat: add universe_domain option for TPC feat: add universe_domain attribute to ClientOptions Nov 20, 2023
@ohmayr ohmayr merged commit 3069ef4 into main Nov 20, 2023
@ohmayr ohmayr deleted the feature/add-universe-domain-option-for-tpc branch November 20, 2023 19:19
@release-please release-please bot mentioned this pull request Nov 17, 2023
Merged
@parthea parthea changed the title feat: add universe_domain attribute to ClientOptions feat: add universe_domain argument to ClientOptions Nov 20, 2023
@parthea parthea added the release-please:force-run To run release-please label Nov 20, 2023
@release-please release-please bot removed the release-please:force-run To run release-please label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

+1 more reviewer

@arithmetic1728 arithmetic1728 arithmetic1728 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Add support for universe_domain as a client option for TPC
3 participants
@ohmayr @parthea @arithmetic1728