Skip to content

feat: update recognized logging fields #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024
Merged

feat: update recognized logging fields #766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion google/api_core/client_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,13 @@
"rpcName",
"serviceName",
"credentialsType",
"credentialInfo",
"credentialsInfo",
"universeDomain",
"request",
"response",
"metadata",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the parent design doc, we should still have rpcName, right? (We're using it in the pending PR in the generator)

Copy link
Contributor Author

@ohmayr ohmayr Dec 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we should. I see it here it in the list. Let me know if you see otherwise.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my bad. Don't know why I didn't see it before.

"retryAttempt",
"httpResponse",
] # Additional fields to be Logged.


Expand Down
Loading