Skip to content

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Jul 19, 2022

Some context around this PR:

These proto files are no longer used in the main client library. They only exist to assist in migration for packages that need to support google-cloud-bigquery 2.x and 3.x. Instead, a dictionary of the REST resource is exposed for the BQML-related statistics. This choice was made for a few reasons:

  • The backend team rarely publishes the updates they make to these protos to https://github.com/googleapis/googleapis/tree/master/google/cloud/bigquery Instead, historically the client libraries team has had to manually update them.
  • Sometimes the BQML team makes (unintentional?) breaking changes to the proto definitions. Since these protos are only manually updated, those breaking changes are only caught much later.
  • The proto files are only used by the Python client library, not any of the other client libraries.
  • The proto files only include a small subset of the BigQuery v2 interface.
  • The presence of these proto files occasionally confuses members of the backend team into thinking the BigQuery v2 API supports gRPC and/or GAPIC client library generation.

Resources

Towards #814

@tswast tswast requested a review from a team July 19, 2022 18:39
@tswast tswast requested a review from a team as a code owner July 19, 2022 18:39
@tswast tswast requested a review from prash-mi July 19, 2022 18:39
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jul 19, 2022
@tswast
Copy link
Contributor Author

tswast commented Jul 20, 2022

@tswast tswast requested a review from parthea July 20, 2022 21:07
@parthea parthea self-assigned this Aug 12, 2022
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 15, 2022
@tswast tswast closed this Aug 15, 2022
@tswast tswast reopened this Aug 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2022
@aribray aribray added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2022
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Nov 18, 2022
@parthea parthea enabled auto-merge (squash) December 14, 2022 16:25
@parthea parthea merged commit b8502a6 into main Dec 14, 2022
@parthea parthea deleted the tswast-patch-2 branch December 14, 2022 16:49
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
* chore: remove code generation for BQML proto files

* remove protos from owlbot config

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: aribray <45905583+aribray@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants