Skip to content

Conversation

shollyman
Copy link
Contributor

This PR adds support for incremental query stats.

This PR adds support for incremental query stats.
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Aug 26, 2025
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one question. See inline comment.

If you have to make a change, ping me, I will come back and reapprove.

Comment on lines +246 to +247
"""Optional[datetime]: The time at which the result table's contents
were completely replaced. May be absent if no results have been written
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#QUESTION

Is there supposed to be a difference between last_replace_time and last_modify_time?

The docstrings are identical.

@shollyman shollyman added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants