test: update tests to support latest google-cloud-core #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by default. Update the connection tests to expect a value for `prettyPrint`.
3f1ebe2 to
d5ed504
Compare
busunkim96
approved these changes
Oct 5, 2020
steffnay
approved these changes
Oct 6, 2020
parthea
pushed a commit
that referenced
this pull request
Mar 12, 2022
`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by default. Update the connection tests to expect a value for `prettyPrint`.
tswast
added a commit
that referenced
this pull request
Mar 25, 2022
…1166) * chore(deps): allow google-api-core v2 on v1 release * chore: also update cloud-core * test: update tests to support latest google-cloud-core (#276) `google-cloud-core` version 1.4.2 populates `prettyPrint=false` by default. Update the connection tests to expect a value for `prettyPrint`. * ci: fix docs build * chore: update system tests and samples to use and @google.com email address (#942) * chore: update system tests and samples to use and @google.com email address * Add group prefix * fixed access entry some more Co-authored-by: Tim Swast <swast@google.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: Jim Fulton <jim@jimfulton.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
google-cloud-coreversion 1.4.2 populatesprettyPrint=falsebydefault. Update the connection tests to expect a value for
prettyPrint.This PR also serves to test that the changes in googleapis/python-cloud-core#28 do not break this library.
Closes #294