chore: Prepare for 2.0 release #278

plamut · 2020-09-25T16:19:34Z

This PR should serve as a preview of the 2.0 release.

For a start, the BQ Storage v1beta1 compatibility code is removed, as it will not be needed anymore once BQ Storage v2.0.0 is released.

TODO list:

Fix import paths in tests and samples that are affected by bigquery_v2 changes.
Describe bigquery_v2 changes in UPGRADING guide.
Fix docs, include bigquery_v2 in them, if necessary.

plamut · 2020-09-29T16:43:03Z

BQ Storage 2.0.0 released, re-running.

setup.py

UPGRADING.md

docs/bigquery_v2/services.rst

google/cloud/bigquery/dbapi/connection.py

docs/bigquery_v2/types.rst

google/cloud/bigquery/table.py

google/cloud/bigquery_v2/services/__init__.py

tests/unit/test_dbapi_connection.py

tests/unit/enums/test_standard_sql_data_types.py

plamut · 2020-09-30T13:51:08Z

FWIW, the snippets tests in samples/snippets fail because the generated noxfile tries to install BigQuery v1.x, but the snippets require v2.0.0 that is still in the making. They pass locally if INSTALL_LIBRARY_FROM_SOURCE env variable is set and the following patch is applied:

diff --git samples/snippets/noxfile.py samples/snippets/noxfile.py
index 5660f08..66589f5 100644
--- samples/snippets/noxfile.py
+++ samples/snippets/noxfile.py
@@ -158,14 +158,17 @@ def _session_tests(session, post_install=None):
         session.install("-r", "requirements-test.txt")
 
     if INSTALL_LIBRARY_FROM_SOURCE:
-        session.install("-e", _get_repo_root())
+        session.install("-e", _get_repo_root() + "[all]")
 
     if post_install:
         post_install(session)
 
diff --git samples/snippets/requirements.txt samples/snippets/requirements.txt
index 7fe8391..4753c47 100644
--- samples/snippets/requirements.txt
+++ samples/snippets/requirements.txt
@@ -1,4 +1,4 @@
-google-cloud-bigquery[pandas,bqstorage,pyarrow]==1.26.1
+# google-cloud-bigquery[pandas,bqstorage,pyarrow]==1.26.1
 google-auth-oauthlib==0.4.1
 ipython==7.16.1; python_version < '3.7'
 ipython==7.17.0; python_version >= '3.7'

tswast · 2020-09-30T14:21:55Z

They pass locally if INSTALL_LIBRARY_FROM_SOURCE env variable is set and the following patch is applied:

Do we need to add the necessary extras to requirements.txt?

The assertion seems to fail for a banal reason, i.e. an extra newline in the string representation.

tswast · 2020-09-30T14:33:19Z

Since it looks like requirements.txt is used to install packages, even when INSTALL_LIBRARY_FROM_SOURCE is set, I'm a bit confused as to why pandas isn't getting installed.

python-bigquery/samples/snippets/noxfile.py

Line 155 in fbbe0cb

session.install("-r", "requirements.txt")

Maybe I missed some logic that filters out google-cloud-bigquery[pandas,...] from that installation?

plamut · 2020-09-30T14:35:54Z

@tswast Ah, I think that's probably because I temporarily commented out the google-cloud-python line from requirements.txt completely, I just wanted to test with a local version of the library.

(and then had to adjust the installation from source line in noxfile to actually get all those extras installed)

testing/constraints-3.6.txt

There are currently no public API endpoints for the ModelServiceClient, thus there is no point in generating that code in the first place.

The old pin (1.4.0) does not work, tests detected some problem.

testing/constraints-3.6.txt

docs/bigquery_v2/services.rst

docs/reference.rst

google/cloud/bigquery/model.py

crwilcox · 2020-09-30T21:47:13Z

Hammer merging to work around sample tests.

plamut · 2020-09-30T21:56:42Z

@crwilcox Thanks!

Release PR (#284) will probably need the same hammer love.

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2020

plamut mentioned this pull request Sep 25, 2020

chore: Release v2.0.0 googleapis/python-bigquery-storage#64

Merged

product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Sep 26, 2020

plamut force-pushed the prepare-for-2-0 branch from ace6762 to 8795ec8 Compare September 27, 2020 16:26

plamut added 7 commits September 28, 2020 19:43

Remove BQ Storage v1beta1 compatibility code

620724e

Adjust code to new BQ Storage 2.0

94345ae

Remove Python 2/3 compatibility code

f5d9403

Bump test coverage to 100%

c2eb9b7

Update supported Python versions in README

13908c3

Add UPGRADING guide.

62fa539

Regenerate bigquery_v2 code with microgenerator

94c50cf

plamut force-pushed the prepare-for-2-0 branch from 74257b1 to 94c50cf Compare September 28, 2020 17:46

tswast mentioned this pull request Sep 29, 2020

Feature Request: allow clients to act as context manager and add close() method to cleanup resources googleapis/gapic-generator-python#575

Closed

plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2020

tswast reviewed Sep 29, 2020

View reviewed changes

This was referenced Sep 29, 2020

chore(deps): update dependency google-cloud-bigquery-storage to v2 #282

Closed

feat: add constants for MONTH and YEAR time partitioning types #283

Merged

Adjust hand-written unit tests to regened BQ v2

68328c3

plamut commented Sep 30, 2020

View reviewed changes

tests/unit/enums/test_standard_sql_data_types.py Outdated Show resolved Hide resolved

plamut added 2 commits September 30, 2020 16:00

Adjust samples to BQ v2 regenerated code

9b26cf9

Adjust system tests to regenerated BQ v2

eb3354c

tswast mentioned this pull request Sep 30, 2020

enum classes are missing docstrings googleapis/gapic-generator-python#625

Closed

Skip failing generated unit test

40eddb7

The assertion seems to fail for a banal reason, i.e. an extra newline in the string representation.

plamut added 6 commits September 30, 2020 17:11

Delete Kokoro config for Python 2.7

f490218

Fix docs build

755ff95

Undelete failing test, but mark as skipped

045596e

Fix namespace name in docstrings and comments

ecbf475

Define minimum dependency versions for Python 3.6

e39fda2

Exclude autogenerated docs from docs index

49b06a4

plamut commented Sep 30, 2020

View reviewed changes

testing/constraints-3.6.txt Show resolved Hide resolved

plamut commented Sep 30, 2020

View reviewed changes

testing/constraints-3.6.txt Show resolved Hide resolved

plamut marked this pull request as ready for review September 30, 2020 17:36

plamut requested a review from a team September 30, 2020 17:36

plamut requested a review from a team as a code owner September 30, 2020 17:36

plamut requested a review from dinagraves September 30, 2020 17:36

Exclude generated services from the library

7a4084e

There are currently no public API endpoints for the ModelServiceClient, thus there is no point in generating that code in the first place.

plamut force-pushed the prepare-for-2-0 branch from e31d97a to 7a4084e Compare September 30, 2020 18:18

plamut added 2 commits September 30, 2020 21:11

Bump minumum proto-plus version to 1.10.0

64d6660

The old pin (1.4.0) does not work, tests detected some problem.

Include generated types in the docs and rebuild

73c2da8

tswast reviewed Sep 30, 2020

View reviewed changes

testing/constraints-3.6.txt Show resolved Hide resolved

docs/bigquery_v2/services.rst Show resolved Hide resolved

docs/reference.rst Show resolved Hide resolved

Ignore skipped test in coverage check

c976ce5

tswast reviewed Sep 30, 2020

View reviewed changes

google/cloud/bigquery/model.py Show resolved Hide resolved

tswast approved these changes Sep 30, 2020

View reviewed changes

Explain moved enums in UPGRADING guide

2690ec7

tswast approved these changes Sep 30, 2020

View reviewed changes

crwilcox merged commit cbcb4b8 into googleapis:master Sep 30, 2020

plamut deleted the prepare-for-2-0 branch September 30, 2020 22:52

plamut mentioned this pull request Oct 1, 2020

Transition the library to the new microgenerator #147

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: Prepare for 2.0 release #278

chore: Prepare for 2.0 release #278

Uh oh!

plamut commented Sep 25, 2020 •

edited

Loading

Uh oh!

plamut commented Sep 29, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

plamut commented Sep 30, 2020

Uh oh!

tswast commented Sep 30, 2020

Uh oh!

tswast commented Sep 30, 2020

Uh oh!

plamut commented Sep 30, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

crwilcox commented Sep 30, 2020

Uh oh!

plamut commented Sep 30, 2020

Uh oh!

Uh oh!

chore: Prepare for 2.0 release #278

chore: Prepare for 2.0 release #278

Uh oh!

Conversation

plamut commented Sep 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

plamut commented Sep 29, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

plamut commented Sep 30, 2020

Uh oh!

tswast commented Sep 30, 2020

Uh oh!

tswast commented Sep 30, 2020

Uh oh!

plamut commented Sep 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

crwilcox commented Sep 30, 2020

Uh oh!

plamut commented Sep 30, 2020

Uh oh!

Uh oh!

plamut commented Sep 25, 2020 •

edited

Loading

plamut commented Sep 30, 2020 •

edited

Loading