Skip to content

fix: remove unnecessary dependency on libcst #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2020
Merged

fix: remove unnecessary dependency on libcst #308

merged 3 commits into from
Oct 8, 2020

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Oct 7, 2020 •
edited
Loading

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #302 🦕

@tswast tswast requested a review from a team October 7, 2020 16:14
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2020
@tswast
Copy link
Contributor Author

tswast commented Oct 7, 2020

Ran synthtool locally and verified that the "fixup" script stays excluded.

@di di mentioned this pull request Oct 8, 2020
Closed
@tswast tswast merged commit c055930 into googleapis:master Oct 8, 2020
@tswast tswast deleted the issue302-libcst branch October 8, 2020 15:19
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 8, 2020
@release-please
chore: release 2.1.0 (#301)
1a4dc12 
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.1.0](https://www.github.com/googleapis/python-bigquery/compare/v2.0.0...v2.1.0) (2020-10-08)


### Features

* add constants for MONTH and YEAR time partitioning types ([#283](https://www.github.com/googleapis/python-bigquery/issues/283)) ([9090e1c](https://www.github.com/googleapis/python-bigquery/commit/9090e1ccd8825a97835325b4829f6e7ecfd9ea88))


### Bug Fixes

* remove unnecessary dependency on libcst ([#308](https://www.github.com/googleapis/python-bigquery/issues/308)) ([c055930](https://www.github.com/googleapis/python-bigquery/commit/c05593094c1405f752b2c51b15202a6dbb5cb83f))


### Performance Improvements

* remove redundant array deepcopy ([#26](https://www.github.com/googleapis/python-bigquery/issues/26)) ([b54f867](https://www.github.com/googleapis/python-bigquery/commit/b54f86769c982ce5c8fcbf3889f82450428bb40c))


### Documentation

* **samples:** add create_table_clustered code snippet ([#291](https://www.github.com/googleapis/python-bigquery/issues/291)) ([d1eb8b3](https://www.github.com/googleapis/python-bigquery/commit/d1eb8b3dcc789916c5d3ba8464f62b1f8bef35ff))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@HemangChothani HemangChothani mentioned this pull request Oct 9, 2020
Merged
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@steffnay steffnay steffnay approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google-cloud-bigquery not compatible with pandas-gbq error
2 participants
@tswast @steffnay