Skip to content

feat: add context manager support to client #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2021
Merged

feat: add context manager support to client #540

merged 1 commit into from
Mar 9, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Mar 3, 2021 •
edited
Loading

Closes #538.

This PR adds context manager capabilities to BigQuery client.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut requested review from a team and steffnay and removed request for a team March 3, 2021 11:57
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Mar 3, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 3, 2021
@plamut plamut requested a review from tswast March 3, 2021 11:58
tswast
tswast approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@tswast tswast merged commit d5c7e11 into googleapis:master Mar 9, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 9, 2021
@release-please
chore: release 2.11.0 (#545)
3ce826e 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.11.0](https://www.github.com/googleapis/python-bigquery/compare/v2.10.0...v2.11.0) (2021-03-09)


### Features

* add context manager support to client ([#540](https://www.github.com/googleapis/python-bigquery/issues/540)) ([d5c7e11](https://www.github.com/googleapis/python-bigquery/commit/d5c7e11a1dc2a149d74294bfadbae62d70573e69))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@plamut plamut deleted the iss-538 branch March 9, 2021 21:16
This was referenced Mar 10, 2021
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
@ncclementi ncclementi mentioned this pull request Aug 18, 2021
Closed
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
emkornfield pushed a commit to emkornfield/python-bigquery that referenced this pull request Feb 11, 2023
@dpebot @shollyman
Auto-update dependencies. [(googleapis#540)](GoogleCloudPlatform/pyth…
04ac014 
…on-docs-samples#540)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@steffnay steffnay Awaiting requested review from steffnay

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for with statement for Client class
2 participants
@plamut @tswast