chore: internal version of resample. #1004
Conversation
e8ec920 to
240c1e8
Compare
| col_id = self.index.resolve_level(level)[0] | ||
| # Reset index to make the resampling level a column, then drop all other index columns. | ||
| # This simplifies processing by focusing solely on the column required for resampling. | ||
| block = self.reset_index(drop=False) |
There was a problem hiding this comment.
I think this might require a total ordering in BigFrames to work. Could you run some tests with unordered mode + a timestamp index that has non-unique values?
There was a problem hiding this comment.
Added a test for unordered mode and with duplicate values, seems runs fine. I don't think the order matters here, in the end we are not keeping this order.
bigframes/core/blocks.py
Outdated
| # Validate and resolve the index or column to use for grouping | ||
| if on is None: | ||
| if len(self.index_columns) == 0: | ||
| raise TypeError("Index type not valid. Expected Datetime Type.") |
There was a problem hiding this comment.
Could you double check the error message?
bigframes/series.py
Outdated
| Args: | ||
| rule (str): | ||
| The offset string representing target conversion. | ||
| on (str, default None): |
There was a problem hiding this comment.
The doc arguments isn't match the function definition. Could you double check?
| 'epoch': origin is 1970-01-01 | ||
| 'start': origin is the first value of the timeseries | ||
| 'start_day': origin is the first day at midnight of the timeseries | ||
| Returns: |
There was a problem hiding this comment.
Please add "Examples" too? Though it's an internal API.
| elif origin == "start": | ||
| return y.cast(ibis_dtypes.Timestamp(timezone="UTC")).cast(ibis_dtypes.int64) | ||
| else: | ||
| raise ValueError(f"Origin {origin} not supported") |
There was a problem hiding this comment.
Could you please add some tests to cover this line of codes?
There was a problem hiding this comment.
Added two xfail tests for on and origin, but this line of code should be unreachable.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕