refactor: move reader functions from __init__.py to a separate file under the pandas package
#1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nder pandas package
tswast
reviewed
Sep 26, 2024
bigframes/pandas/readers.py
Outdated
There was a problem hiding this comment.
Could we make this [bigframes/pandas/io/parsers/readers.py](https://github.com/pandas-dev/pandas/blob/23c497bb2f7e05af1fda966e7fb04db942453559/pandas/io/parsers/readers.py#L720) to better match the pandas code layout?
There was a problem hiding this comment.
Or bigframes/pandas/io/api.py if we want to go one layer of indirection fewer
There was a problem hiding this comment.
Sounds good. I put all the functions under the api.py file since they are relatively simple
There was a problem hiding this comment.
The docs of these methods are stayed at third_party/bigframes_vendored/pandas/io/parsers/readers.py. Should we keep them in the similar path?
ed79ff2 to
18e52cc
Compare
…/python-bigquery-dataframes into sycai-refactor-pandas
chelsea-lin
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.