fix: use table clone instead of system time for read_gbq_table
#109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5530aaf to
42c70f5
Compare
ashleyxuu
reviewed
Nov 3, 2023
bigframes/session/_io/bigquery.py
Outdated
| """ | ||
| ) | ||
| job_config = bigquery.QueryJobConfig() | ||
| job_config.labels = {"bigframes-api": api_name} |
There was a problem hiding this comment.
Do we need to add "source": "bigquery-dataframes-temp" as well?
There was a problem hiding this comment.
Will do! FYI: That label is for internal issue 296779699. The original request was to either add it to the job that created the table or the table itself. Wouldn't hurt to do both.
ashleyxuu
approved these changes
Nov 3, 2023
This was referenced Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore(reverted): use table clone instead of system time for read_gbq_table
END_COMMIT_OVERRIDE
Towards internal issue 301645192 to have lower-cost default ordering.
Blocked by internal issue 305235665
Closes internal issue 301459572