Skip to content

refactor: Tweak notebooks to test minimal IAM permissions #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 21, 2023
Merged

refactor: Tweak notebooks to test minimal IAM permissions #123

merged 5 commits into from
Oct 21, 2023

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Oct 19, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/304758084 🦕

@shobsi shobsi requested review from a team as code owners October 19, 2023 20:14
@shobsi shobsi requested a review from TrevorBergeron October 19, 2023 20:14
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 19, 2023
@shobsi shobsi merged commit ba2e824 into main Oct 21, 2023
@shobsi shobsi deleted the shobs-minimal-notebooks branch October 21, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron TrevorBergeron is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shobsi @tswast