Skip to content

feat: add Linear_Regression.global_explain() #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Mar 25, 2025
Merged

Conversation

rey-esp
Copy link
Contributor

@rey-esp rey-esp commented Mar 3, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 3, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Mar 4, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Mar 11, 2025
@rey-esp rey-esp marked this pull request as ready for review March 17, 2025 21:39
@rey-esp rey-esp requested review from a team as code owners March 17, 2025 21:39
Copy link

snippet-bot bot commented Mar 17, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@rey-esp rey-esp requested review from tswast and chelsea-lin March 24, 2025 17:55
@tswast tswast merged commit 7e5b6a8 into main Mar 25, 2025
21 of 24 checks passed
@tswast tswast deleted the b338872698-global-explain branch March 25, 2025 19:44
shobsi pushed a commit that referenced this pull request Mar 28, 2025
* feat: add Linear_Regression.global_explain()

* remove class_level_explain param

* working global_explain()

* begin adding tests

* update snippet

* complete snippet

* failing, near complete linear model test

* passing system test

* Update core.py - set index to have sorted by feature

* Update test_linear_model.py - remove set/set index

* Update linear_model.py - fix doc section

* Update conftest.py - rename penguins w global explain

* Update linear_model.py - complete doc

* lint

* passing test and fixed expected results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants