Skip to content

fix: tolerate BQ connection service account propagation delay #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

fix: tolerate BQ connection service account propagation delay #1505

merged 1 commit into from
Mar 20, 2025

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Mar 18, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 397662004 🦕

@shobsi shobsi requested review from tswast and GarrettWu March 18, 2025 22:39
@shobsi shobsi requested review from a team as code owners March 18, 2025 22:39
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 18, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Mar 18, 2025
@shobsi
Copy link
Contributor Author

shobsi commented Mar 20, 2025

Merging this despite e2e failure because the failure is unrelated to this change (related to tenant project quota issue in cloud run) and the change itself is simple.

@shobsi shobsi merged commit 6681f1f into main Mar 20, 2025
23 of 24 checks passed
@shobsi shobsi deleted the shobs-wait-for-conn-sa branch March 20, 2025 20:53
@release-please release-please bot mentioned this pull request Mar 20, 2025
Merged
shobsi added a commit that referenced this pull request Mar 28, 2025
@shobsi
fix: tolerate BQ connection service account propagation delay (#1505)
6374662
@release-please release-please bot mentioned this pull request Mar 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@GarrettWu GarrettWu Awaiting requested review from GarrettWu

Assignees

@arwas11 arwas11

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shobsi @tswast @arwas11