Skip to content

chore: assert test udfs active deletion, make pre-commit mypy dep consistent with nox #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

chore: assert test udfs active deletion, make pre-commit mypy dep consistent with nox #1522

merged 1 commit into from
Mar 24, 2025

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Mar 21, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@shobsi shobsi requested review from a team as code owners March 21, 2025 06:38
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 21, 2025
@shobsi shobsi changed the title chore: ensure udfs are actively deleted, make pre-commit mypy dep consistent with nox chore: assert test udf active deletion, make pre-commit mypy dep consistent with nox Mar 21, 2025
@shobsi shobsi changed the title chore: assert test udf active deletion, make pre-commit mypy dep consistent with nox chore: assert test udfs active deletion, make pre-commit mypy dep consistent with nox Mar 21, 2025
@shobsi
Copy link
Contributor Author

shobsi commented Mar 24, 2025

Merging despite the e2e failures, which is due to the cloud run quota issue and being investigated.

@shobsi shobsi merged commit 499e00a into main Mar 24, 2025
23 of 24 checks passed
@shobsi shobsi deleted the shobs-udf-no-ignore-cleanup-failure branch March 24, 2025 16:51
shobsi added a commit that referenced this pull request Mar 28, 2025
@shobsi
chore: ensure udfs are actively deleted, make pre-commit mypy dep con…
65fd038 
…sistent (#1522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu left review comments

@jialuoo jialuoo jialuoo approved these changes

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron

@sycai sycai Awaiting requested review from sycai

@shuoweil shuoweil Awaiting requested review from shuoweil

Assignees

@jiaxunwu jiaxunwu

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shobsi @GarrettWu @jialuoo @jiaxunwu