Skip to content

test: fix json tests fail locally with disable allow_large_results #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2025
Merged

test: fix json tests fail locally with disable allow_large_results #1523

merged 3 commits into from
Mar 21, 2025

Conversation

chelsea-lin
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@chelsea-lin chelsea-lin requested review from a team as code owners March 21, 2025 17:38
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 21, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_fixjsontests branch from 4ef05ca to de804b0 Compare March 21, 2025 19:53
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 21, 2025
@chelsea-lin chelsea-lin merged commit ab2455f into main Mar 21, 2025
23 of 24 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_fixjsontests branch March 21, 2025 21:42
shobsi pushed a commit that referenced this pull request Mar 28, 2025
@chelsea-lin @shobsi
test: fix json tests fail locally with disable allow_large_results (#…
873709e 
…1523)

* test: fix json tests fail locally with disable allow_large_results

* fix test_read_gbq_w_json_in_array

* move test_read_gbq_w_json* to test_session.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrevorBergeron TrevorBergeron TrevorBergeron approved these changes

Assignees

@ZehaoXU ZehaoXU

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chelsea-lin @TrevorBergeron @ZehaoXU