fix: Raise error for large inline DataFrames in read_pandas #1525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f673f3 to
d03d747
Compare
d03d747 to
ebe965a
Compare
sycai
approved these changes
Mar 24, 2025
shobsi
pushed a commit
that referenced
this pull request
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
read_pandas(..., write_engine="bigquery_inline")would incorrectly return None for DataFrames exceedingMAX_INLINE_DF_BYTES. This PR ensures aValueErroris raised as expected. Additionally, it refactors the internal_read_pandas_inlinemethod for improved readability and test coverage.