Skip to content

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented Mar 24, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
    • difference: screen/p6wtJLPa9ebR8bJ, screen/4RqGh6Pyru6aMCr, screen/C3Si6U97PhuGdbx, screen/87EqhxARU5XHGhV
    • st_difference: screen/8KoAcYitnbf4zyb, screen/Wjy2s3y7Ne5PHRZ, screen/AKwQUj6hMiHvHsu, screen/8FMjy2Jfq38uEH5

Fixes #400711766 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 24, 2025
@arwas11 arwas11 marked this pull request as ready for review March 24, 2025 17:22
@arwas11 arwas11 requested review from a team as code owners March 24, 2025 17:22
@arwas11 arwas11 requested a review from chelsea-lin March 24, 2025 17:22
@arwas11
Copy link
Contributor Author

arwas11 commented Mar 24, 2025

Unrelated notebook failure

=========================== short test summary info ============================
FAILED notebooks/generative_ai/large_language_models.ipynb::large_language_models.ipynb

@arwas11 arwas11 requested a review from chelsea-lin March 24, 2025 18:29
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arwas11 arwas11 enabled auto-merge (squash) March 25, 2025 15:59
@arwas11 arwas11 merged commit d553fa2 into main Mar 25, 2025
17 of 24 checks passed
@arwas11 arwas11 deleted the b400711766-geo-difference-docs branch March 25, 2025 16:25
shobsi pushed a commit that referenced this pull request Mar 28, 2025
…erence()` docs (#1526)

* docs: update GeoSeries.difference() and bigframes.bigquery.st_difference() docs

* update variable names for readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants