Skip to content

feat: add GeoSeries.intersection() and bigframes.bigquery.st_intersection() #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 26, 2025
Merged

feat: add GeoSeries.intersection() and bigframes.bigquery.st_intersection() #1529

merged 13 commits into from
Mar 26, 2025

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented Mar 24, 2025 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
    • intersection: screen/C59Lzg7NrKLvLK8, screen/9vQJhRAK3o2peTw, screen/BJwFw4JGxMUssTJ
    • st_intersection: screen/3Snpi2mzoWYvkgH, screen/3NACQ7AHETjMLd5, screen/FtQSyjCGCahYDqY

Fixes #405996187 🦕

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 24, 2025
@arwas11 arwas11 marked this pull request as ready for review March 25, 2025 15:59
@arwas11 arwas11 requested review from a team as code owners March 25, 2025 15:59
@arwas11 arwas11 requested a review from GarrettWu March 25, 2025 15:59
tswast
tswast approved these changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast tswast enabled auto-merge (squash) March 25, 2025 22:02
@tswast tswast disabled auto-merge March 25, 2025 22:03
@tswast
Copy link
Collaborator

tswast commented Mar 25, 2025

Please wait for doctest to pass before merging.

@arwas11
Copy link
Contributor Author

arwas11 commented Mar 26, 2025 •
edited
Loading

Please wait for doctest to pass before merging.

Failing doctest and e2e are unrelated to GeoSeries.

doctest :
=========================== short test summary info ============================
FAILED third_party/bigframes_vendored/pandas/core/series.py::series.Series.mask

e2e:
=========================== short test summary info ============================
FAILED tests/system/small/test_encryption.py::test_bqml - google.api_core.exc...
FAILED tests/system/small/ml/test_imported.py::test_xgboost_model_predict - g...
FAILED tests/system/small/ml/test_imported.py::test_xgboost_model_to_gbq - go...
FAILED tests/system/small/ml/test_impute.py::test_simple_imputer_fit_transform_default_params
FAILED tests/system/small/ml/test_impute.py::test_simple_imputer_series - goo...
FAILED tests/system/small/ml/test_llm.py::test_create_text_generator_model_default_session
FAILED tests/system/small/ml/test_impute.py::test_simple_imputer_save_load_mean
FAILED tests/system/small/ml/test_llm.py::test_create_text_generator_32k_model_default_session
FAILED tests/system/small/ml/test_imported.py::test_tensorflow_model_predict
FAILED tests/system/small/ml/test_impute.py::test_simple_imputer_save_load_most_frequent
FAILED tests/system/small/ml/test_linear_model.py::test_linear_reg_model_global_explain
...

@arwas11 arwas11 merged commit 8542bd4 into main Mar 26, 2025
22 of 24 checks passed
@arwas11 arwas11 deleted the b405996187-geo-intersection branch March 26, 2025 15:38
@release-please release-please bot mentioned this pull request Mar 26, 2025
Merged
shobsi pushed a commit that referenced this pull request Mar 28, 2025
@arwas11 @shobsi
feat: add GeoSeries.intersection() and `bigframes.bigquery.st_inter…
d86c6af 
…section()` (#1529)

* feat: add GeoSeries.intersection() and bigframes.bigquery.st_intersection()

* fix docstrings format

* fix docstring output error

* fix docstrings code examples

* fix st_intersection
@release-please release-please bot mentioned this pull request Mar 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@GarrettWu GarrettWu Awaiting requested review from GarrettWu GarrettWu is a code owner automatically assigned from googleapis/api-bigquery-dataframe

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron

Assignees

@ericfe-google ericfe-google

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arwas11 @tswast @ericfe-google