Skip to content

chore: cleanup udf resources in blob transform functions #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 25, 2025
Merged

chore: cleanup udf resources in blob transform functions #1530

merged 4 commits into from
Mar 25, 2025

Conversation

GarrettWu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@GarrettWu GarrettWu requested review from shobsi and shuoweil March 24, 2025 20:52
@GarrettWu GarrettWu self-assigned this Mar 24, 2025
@GarrettWu GarrettWu requested review from a team as code owners March 24, 2025 20:52
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 24, 2025
shuoweil
shuoweil previously approved these changes Mar 24, 2025
View reviewed changes
shobsi
shobsi reviewed Mar 24, 2025
View reviewed changes
shobsi
shobsi reviewed Mar 24, 2025
View reviewed changes
@shuoweil shuoweil self-requested a review March 24, 2025 21:45
@shuoweil shuoweil dismissed their stale review March 24, 2025 21:46

Please wait for shobsi's review

@GarrettWu GarrettWu requested a review from shobsi March 24, 2025 23:08
@shobsi
Copy link
Contributor

shobsi commented Mar 24, 2025

It seems not all tests are using the session fixture (which ensures session.close()), e.g. test_blob_image_blur_to_folder - this means some tests will still leave the BQ udfs behind after this change?

@GarrettWu
Copy link
Contributor Author

It seems not all tests are using the session fixture (which ensures session.close()), e.g. test_blob_image_blur_to_folder - this means some tests will still leave the BQ udfs behind after this change?

It does, implicitly in the input dataframe.

@shuoweil shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2025
@GarrettWu GarrettWu merged commit 06d343c into main Mar 25, 2025
24 checks passed
@GarrettWu GarrettWu deleted the garrettwu-mm-udf branch March 25, 2025 23:01
shobsi pushed a commit that referenced this pull request Mar 28, 2025
@GarrettWu @shobsi
chore: cleanup udf resources in blob transform functions (#1530)
d34c142 
* chore: cleanup udf resources in blob transform functions

* cleanup on session close

* use remote function cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shobsi shobsi shobsi approved these changes

@shuoweil shuoweil shuoweil approved these changes

Assignees

@GarrettWu GarrettWu

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GarrettWu @shobsi @shuoweil @bigframes-bot