Skip to content

feat: add deprecation warning to GeminiTextGenerator model #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 25, 2025
Merged

feat: add deprecation warning to GeminiTextGenerator model #1534

merged 7 commits into from
Mar 25, 2025

Conversation

shuoweil
Copy link
Contributor

@shuoweil shuoweil commented Mar 24, 2025 •
edited
Loading

  • feat: add deprecation warning to GeminiTextGenerator model, especially for gemini-1.5-X, gemini-1.0-X (gemini-pro), and textembedding-gecko
  • all testcases, docs, and notebooks are updated to avoid using gemini-pro
  • b/406066855

@shuoweil shuoweil requested review from GarrettWu and shobsi March 24, 2025 23:02
@shuoweil shuoweil self-assigned this Mar 24, 2025
@shuoweil shuoweil requested review from a team as code owners March 24, 2025 23:02
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 24, 2025
@shuoweil shuoweil force-pushed the shuowei-model-deprecation branch from 5abf4ac to db996f9 Compare March 24, 2025 23:04
@shuoweil shuoweil enabled auto-merge (squash) March 24, 2025 23:04
GarrettWu
GarrettWu reviewed Mar 24, 2025
View reviewed changes
@GarrettWu
Copy link
Contributor

Also update notebooks.

@GarrettWu
Copy link
Contributor

Title. The model is GeminiTextGenerator.

@shuoweil shuoweil requested a review from a team as a code owner March 25, 2025 03:24
@shuoweil shuoweil requested a review from iennae March 25, 2025 03:24
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: s Pull request size is small. labels Mar 25, 2025
@shuoweil shuoweil requested a review from GarrettWu March 25, 2025 03:30
@shuoweil shuoweil changed the title feat: add deprecation warning to TextEmbeddingGenerator model feat: add deprecation warning to GeminiTextGenerator model Mar 25, 2025
@shuoweil
Copy link
Contributor Author

Also update notebooks.

all notebooks have been updated accordingly.

GarrettWu
GarrettWu reviewed Mar 25, 2025
View reviewed changes
@shuoweil shuoweil force-pushed the shuowei-model-deprecation branch from 22763e6 to 5c63641 Compare March 25, 2025 18:16
@shuoweil shuoweil requested a review from GarrettWu March 25, 2025 18:18
@shuoweil shuoweil force-pushed the shuowei-model-deprecation branch from 60061a5 to 6b3adf2 Compare March 25, 2025 20:59
@shuoweil shuoweil merged commit c93e720 into main Mar 25, 2025
19 of 24 checks passed
@shuoweil shuoweil deleted the shuowei-model-deprecation branch March 25, 2025 21:37
@release-please release-please bot mentioned this pull request Mar 25, 2025
Merged
shobsi pushed a commit that referenced this pull request Mar 28, 2025
@shuoweil @shobsi
fix: add deprecation warning to TextEmbeddingGenerator model, espeica…
2d82871 
…lly gemini-1.0-X and gemini-1.5-X (#1534)
@release-please release-please bot mentioned this pull request Mar 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

@shobsi shobsi Awaiting requested review from shobsi

@iennae iennae Awaiting requested review from iennae iennae is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees

@shuoweil shuoweil

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shuoweil @GarrettWu