test: add code snippets for loading data from BigQuery Job #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
tswast
reviewed
Oct 27, 2023
tswast
requested changes
Oct 27, 2023
There was a problem hiding this comment.
Please investigate test failure.
=================================== FAILURES ===================================
_____________ test_bigquery_dataframes_load_data_from_bigquery_job _____________
def test_bigquery_dataframes_load_data_from_bigquery_job():
import bigframes.pandas as bpd
> bpd.options.bigquery.project = "bigframes-dev"
[samples/snippets/load_data_from_biquery_job_test.py:19](https://cs.corp.google.com/piper///depot/google3/samples/snippets/load_data_from_biquery_job_test.py?l=19):
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <bigframes._config.bigquery_options.BigQueryOptions object at 0x7f000edb9a30>
value = 'bigframes-dev'
@project.setter
def project(self, value: Optional[str]):
if self._session_started and self._project != value:
> raise ValueError(SESSION_STARTED_MESSAGE.format(attribute="project"))
E ValueError: Cannot change 'project' once a session has started. Call bigframes.pandas.close_session() first, if you are using the bigframes.pandas API.
[bigframes/_config/bigquery_options.py:100](https://cs.corp.google.com/piper///depot/google3/bigframes/_config/bigquery_options.py?l=100): ValueError
=============================== warnings summary ===============================
tswast
reviewed
Oct 27, 2023
tswast
approved these changes
Oct 30, 2023
tswast
requested changes
Oct 30, 2023
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes b/297502513 🦕
orrbradford
pushed a commit
that referenced
this pull request
Oct 31, 2023
* test: add code snippets for loading data from BigQuery Job * fix: address the comments * fix: fix the broken test * use BigQuery Client library to get the job_id * feat: Implement operator `@` for `DataFrame.dot` (#139) Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes b/297502513 🦕 * fix: fix the comments --------- Co-authored-by: Shobhit Singh <shobs@google.com>
ashleyxuu
added a commit
that referenced
this pull request
Nov 1, 2023
* test: add code snippets for loading data from BigQuery Job * fix: address the comments * fix: fix the broken test * use BigQuery Client library to get the job_id * feat: Implement operator `@` for `DataFrame.dot` (#139) Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes b/297502513 🦕 * fix: fix the comments --------- Co-authored-by: Shobhit Singh <shobs@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕