chore: replace api_name with updated method_logger #1660
+191
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Genesis929 It looks like there are some conflicts to resolve before this can be fully reviewed. |
tswast
reviewed
May 6, 2025
tests/unit/core/test_log_adapter.py
Outdated
| api_methods = log_adapter.get_and_reset_api_methods() | ||
| assert "testclass-my_field" in api_methods | ||
|
|
||
| assert "<locals>-method1" in api_methods |
There was a problem hiding this comment.
Are these characters allowed?
Keys and values can contain only lowercase letters, numeric characters, underscores, and dashes.
https://cloud.google.com/bigquery/docs/labels-intro#requirements
I think we need some logic to remove invalid characters.
There was a problem hiding this comment.
These characters should only exist in tests, unless someone uses them in a similar way. Updated in case someone actually uses them this way.
Genesis929
commented
May 12, 2025
| @@ -213,12 +224,24 @@ def wrapped(*args, **kwargs): | |||
| ) | |||
|
|
|||
|
|
|||
| def log_name_override(name: str): | |||
There was a problem hiding this comment.
added a decorator for cases where the logged method name is not the same as the real method name. This is for _read_gbq_colab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕