Skip to content

feat: add describe() method to Series #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 17, 2025
Merged

feat: add describe() method to Series #1827

merged 8 commits into from
Jun 17, 2025

Conversation

sycai
Copy link
Contributor

@sycai sycai commented Jun 16, 2025 •
edited
Loading

Moved the describe() logic from DataFrame to a separate library file so that it can be re-used by Series too.

Fixes #385141970

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jun 16, 2025
@sycai sycai marked this pull request as ready for review June 16, 2025 21:47
@sycai sycai requested review from a team as code owners June 16, 2025 21:47
@sycai sycai requested a review from jialuoo June 16, 2025 21:47
@sycai sycai requested review from tswast and chelsea-lin June 16, 2025 23:07
chelsea-lin
chelsea-lin reviewed Jun 16, 2025
View reviewed changes
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably want to update docs too. Moving describe method from third_party/bigframes_vendored/pandas/core/frame.py to common.py.

@sycai
Copy link
Contributor Author

sycai commented Jun 17, 2025

we probably want to update docs too. Moving describe method from third_party/bigframes_vendored/pandas/core/frame.py to common.py.

Good call. Updated the docs too. I still opt for the separate doc approach, because I removed the unnecessary "include" parameter for series.describe(): it is ignored in Pandas anyway: https://pandas.pydata.org/docs/reference/api/pandas.Series.describe.html#:~:text=A%20white%20list%20of%20data%20types%20to%20include%20in%20the%20result.%20Ignored%20for%20Series

@sycai sycai requested a review from chelsea-lin June 17, 2025 00:29
@sycai sycai merged commit a4205f8 into main Jun 17, 2025
20 of 24 checks passed
@sycai sycai deleted the sycai_series_describe branch June 17, 2025 17:59
@release-please release-please bot mentioned this pull request Jun 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

@jialuoo jialuoo jialuoo approved these changes

@tswast tswast Awaiting requested review from tswast

Assignees

@ZehaoXU ZehaoXU

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sycai @chelsea-lin @jialuoo @ZehaoXU