Skip to content

chore: round earlier in TPC-H q15 to try and reduce non-determinism due to aggregating twice #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 7, 2025
Merged

chore: round earlier in TPC-H q15 to try and reduce non-determinism due to aggregating twice #1877

merged 3 commits into from
Jul 7, 2025

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Jul 1, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/384588336 🦕

@tswast tswast requested review from a team as code owners July 1, 2025 18:10
@tswast tswast requested a review from sycai July 1, 2025 18:10
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 1, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Jul 1, 2025
chelsea-lin
chelsea-lin reviewed Jul 1, 2025
View reviewed changes
third_party/bigframes_vendored/tpch/queries/q15.py Outdated
max_revenue_suppliers["TOTAL_REVENUE"] = max_revenue_suppliers[
"TOTAL_REVENUE"
].round(2)
max_revenue_suppliers["TOTAL_REVENUE"] = max_revenue_suppliers["TOTAL_REVENUE"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this line?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not. Good catch!

@tswast tswast merged commit dba2a6e into main Jul 7, 2025
24 of 25 checks passed
@tswast tswast deleted the b384588336-tpc-h-q15-non-determinism branch July 7, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

@sycai sycai Awaiting requested review from sycai sycai is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@chelsea-lin chelsea-lin

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tswast @chelsea-lin