Skip to content

feat: Add total_rows property to pandas batches iterator #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

feat: Add total_rows property to pandas batches iterator #1888

merged 1 commit into from
Jul 8, 2025

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jul 8, 2025
@TrevorBergeron TrevorBergeron requested review from shuoweil and tswast July 8, 2025 16:21
@TrevorBergeron TrevorBergeron marked this pull request as ready for review July 8, 2025 16:21
@TrevorBergeron TrevorBergeron requested review from a team as code owners July 8, 2025 16:21
@TrevorBergeron TrevorBergeron added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 8, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 8, 2025
@TrevorBergeron TrevorBergeron enabled auto-merge (squash) July 8, 2025 23:21
@TrevorBergeron TrevorBergeron merged commit e3f5e65 into main Jul 8, 2025
25 checks passed
@TrevorBergeron TrevorBergeron deleted the iter_w_attribute branch July 8, 2025 23:24
@release-please release-please bot mentioned this pull request Jul 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuoweil shuoweil shuoweil approved these changes

@tswast tswast Awaiting requested review from tswast

Assignees

@liujiashang liujiashang

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @shuoweil @liujiashang