Skip to content

feat: Add concat pushdown for hybrid engine #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2025
Merged

feat: Add concat pushdown for hybrid engine #1891

merged 3 commits into from
Jul 9, 2025
+58 −1

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jul 8, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review July 9, 2025 20:19
@TrevorBergeron TrevorBergeron requested review from a team as code owners July 9, 2025 20:19
@TrevorBergeron TrevorBergeron requested a review from shuoweil July 9, 2025 20:19
sycai
sycai reviewed Jul 9, 2025
View reviewed changes
tests/system/small/engines/test_concat.py Outdated
scalars_array_value: array_value.ArrayValue,
engine,
):
catted = scalars_array_value.concat([scalars_array_value, scalars_array_value])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming nit: "catted" -> "result". Otherwise I might have thought that the returned value is turned into a feline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

tests/system/small/engines/test_concat.py Outdated
engine,
):
catted = scalars_array_value.concat([scalars_array_value, scalars_array_value])
assert_equivalence_execution(catted.node, REFERENCE_ENGINE, engine)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super style nit: let's add an empty line before the assertion block https://g3doc.corp.google.com/eng/doc/devguide/testing/unit/best-practices.md?cl=head&polyglot=python#structure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@TrevorBergeron TrevorBergeron requested a review from sycai July 9, 2025 21:35
@TrevorBergeron TrevorBergeron enabled auto-merge (squash) July 9, 2025 21:37
@TrevorBergeron TrevorBergeron merged commit 813624d into main Jul 9, 2025
18 of 25 checks passed
@TrevorBergeron TrevorBergeron deleted the hybrid_concat branch July 9, 2025 21:58
@release-please release-please bot mentioned this pull request Jul 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sycai sycai sycai approved these changes

@shuoweil shuoweil shuoweil approved these changes

Assignees

@shuoweil shuoweil

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @sycai @shuoweil