Skip to content

fix: show slot_millis_sum warning only when allow_large_results=False #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

fix: show slot_millis_sum warning only when allow_large_results=False #1892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions bigframes/session/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,13 +339,15 @@ def bytes_processed_sum(self):
@property
def slot_millis_sum(self):
"""The sum of all slot time used by bigquery jobs in this session."""
msg = bfe.format_message(
"Queries executed with `allow_large_results=False` within the session will not "
"have their slot milliseconds counted in this sum. If you need precise slot "
"milliseconds information, query the `INFORMATION_SCHEMA` tables "
"to get relevant metrics.",
)
warnings.warn(msg, UserWarning)
if not bigframes.options._allow_large_results:
msg = bfe.format_message(
"Queries executed with `allow_large_results=False` within the session will not "
"have their slot milliseconds counted in this sum. If you need precise slot "
"milliseconds information, query the `INFORMATION_SCHEMA` tables "
"to get relevant metrics.",
)
warnings.warn(msg, UserWarning)

return self._metrics.slot_millis

@property
Expand Down