feat: Add __contains__ to Index, Series, DataFrame
#1899
Merged
+102
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sycai
previously approved these changes
Jul 10, 2025
Comment on lines
1410
to
1412
| bf_result = scalars_df_index.set_index(col_name).index.__contains__(key) | ||
| pd_result = scalars_pandas_df_index.set_index(col_name).index.__contains__(key) | ||
| assert bf_result == pd_result |
There was a problem hiding this comment.
nit: Let's use key in abc.index for testing instead.
Also empty lines before assertions ;-)
sycai
previously approved these changes
Jul 11, 2025
tests/system/small/test_dataframe.py
Outdated
Comment on lines
4464
to
4466
| bf_result = scalars_df_index.__contains__(key) | ||
| pd_result = scalars_pandas_df_index.__contains__(key) | ||
| assert bf_result == pd_result |
tests/system/small/test_series.py
Outdated
Comment on lines
437
to
439
| bf_result = scalars_df_index["int64_col"].__contains__(key) | ||
| pd_result = scalars_pandas_df_index["int64_col"].__contains__(key) | ||
| assert bf_result == pd_result |
There was a problem hiding this comment.
Shall we update these lines too?
There was a problem hiding this comment.
ahh, missed that one, fixed
sycai
approved these changes
Jul 11, 2025
__contains__ to Index, Series, DataFrame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: Add
__contains__to Index, Series, DataFrame (#1899)END_COMMIT_OVERRIDE
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕