Skip to content

feat: support date data type for to_datetime() #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 11, 2025
Merged

feat: support date data type for to_datetime() #1902

merged 11 commits into from
Jul 11, 2025

Conversation

sycai
Copy link
Contributor

@sycai sycai commented Jul 11, 2025

Fixes #431038295🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jul 11, 2025
@sycai sycai marked this pull request as ready for review July 11, 2025 22:13
@sycai sycai requested review from a team as code owners July 11, 2025 22:13
@@ -28,7 +28,7 @@

def to_datetime(
arg: Union[
Union[int, float, str, datetime],
Union[int, float, str, datetime, date],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring located at third_party/bigframes_vendored/pandas/core/tools/datetimes.py should be updated too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Done.

@sycai sycai requested a review from chelsea-lin July 11, 2025 23:04
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jul 11, 2025
@sycai sycai enabled auto-merge (squash) July 11, 2025 23:20
@sycai sycai merged commit 24050cb into main Jul 11, 2025
18 of 25 checks passed
@sycai sycai deleted the sycai_to_dt branch July 11, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants