Skip to content

chore: update benchmark to assert on empty df returned by to_pandas_batches #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2025
Merged

chore: update benchmark to assert on empty df returned by to_pandas_batches #1907

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de927d4
chore: update benchmark to assert on empty df returned by to_pandas_b…
tswast Jul 14, 2025
0bdbeda
lint
tswast Jul 14, 2025
3a6dd2c
Merge branch 'main' into tswast-patch-1
tswast Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions tests/benchmark/read_gbq_colab/filter_output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import pathlib

import benchmark.utils as utils
import pytest

import bigframes.session

Expand All @@ -40,11 +39,8 @@ def filter_output(

# It's possible we don't have any pages at all, since we filtered out all
# matching rows.
if rows == 0:
with pytest.raises(StopIteration):
next(iter(df_filtered.to_pandas_batches(page_size=PAGE_SIZE)))
else:
next(iter(df_filtered.to_pandas_batches(page_size=PAGE_SIZE)))
first_page = next(iter(df_filtered.to_pandas_batches(page_size=PAGE_SIZE)))
assert len(first_page.index) <= rows


if __name__ == "__main__":
Expand Down