feat: Support audio_transcribe with partial ordering #1908
+139
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78dcbf0 to
abc6dae
Compare
4b2927f to
5560902
Compare
tswast
reviewed
Jul 16, 2025
| @@ -2488,6 +2488,11 @@ def join( | |||
| ) | |||
| if result is not None: | |||
| return result | |||
|
|
|||
| # For block identify joins with null indices, perform cross join | |||
There was a problem hiding this comment.
This doesn't seem desirable. If df1 is n rows and df2 is m rows, won't this end up with n x m rows?
tswast
reviewed
Jul 16, 2025
| result = df.to_pandas(ordered=False) | ||
|
|
||
| assert "transcribed_text" in result.columns | ||
| assert len(result) > 0 |
There was a problem hiding this comment.
The number of rows in result should be exactly equal to the number of rows in audio_mm_df_partial_ordering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Support audio transcription with partial ordering
This change also fixes a related issue where Block.join would fail on joins with null indexes when operating in this partial ordering mode.
b/430572560