Skip to content

chore: fix benchmark file count mismatch issue. #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
Merged

chore: fix benchmark file count mismatch issue. #1909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62b00bd
chore: fix benchmark file count mismatch issue.
Genesis929 Jul 15, 2025
7a6a866
reverse
Genesis929 Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bigframes/session/loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,6 +983,8 @@ def read_gbq_query(
)
job_config.dry_run = True
query_job = self._bqclient.query(query, job_config=job_config)
if self._metrics is not None:
self._metrics.count_job_stats(query_job=query_job)
return dry_runs.get_query_stats_with_inferred_dtypes(
query_job, list(columns), index_cols
)
Expand Down
3 changes: 3 additions & 0 deletions bigframes/session/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ def count_job_stats(
write_stats_to_disk(len(query), total_bytes_processed)
return

if query_job.configuration.dry_run:
write_stats_to_disk(len(query_job.query), 0, 0, 0)

stats = get_performance_stats(query_job)
if stats is not None:
query_char_count, bytes_processed, slot_millis, execution_secs = stats
Expand Down
7 changes: 6 additions & 1 deletion scripts/run_and_publish_benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,12 @@ def collect_benchmark_result(
== len(local_seconds_files)
):
raise ValueError(
"Mismatch in the number of report files for bytes, millis, seconds and query char count."
"Mismatch in the number of report files for bytes, millis, seconds and query char count: \n"
f"millis_files: {len(millis_files)}\n"
f"bq_seconds_files: {len(bq_seconds_files)}\n"
f"bytes_files: {len(bytes_files)}\n"
f"query_char_count_files: {len(query_char_count_files)}\n"
f"local_seconds_files: {len(local_seconds_files)}\n"
)

has_full_metrics = len(bq_seconds_files) == len(local_seconds_files)
Expand Down