feat: provide day_of_year and day_of_week for dt accessor #1911
+102
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelsea-lin
requested changes
Jul 15, 2025
| >>> s = bpd.Series( | ||
| ... pd.date_range('2016-12-31', '2017-01-08', freq='D').to_series() | ||
| ... ) | ||
| >>> s.dt.dayofweek |
| >>> s = bpd.Series( | ||
| ... pd.date_range('2016-12-28', '2017-01-03', freq='D').to_series() | ||
| ... ) | ||
| >>> s.dt.dayofyear |
There was a problem hiding this comment.
s.dt.day_of_year instead?
There was a problem hiding this comment.
pandas uses the same example https://pandas.pydata.org/docs/dev/reference/api/pandas.Series.dt.day_of_week.html
GarrettWu
reviewed
Jul 15, 2025
| @@ -66,6 +66,40 @@ def dayofweek(self): | |||
|
|
|||
| raise NotImplementedError(constants.ABSTRACT_METHOD_ERROR_MESSAGE) | |||
|
|
|||
| @property | |||
| def day_of_week(self): | |||
| """The day of the week with Monday=0, Sunday=6. | |||
There was a problem hiding this comment.
Is it possible to set __doc__ to avoid duplication?
There was a problem hiding this comment.
Like Chelsea just pointed out, there are some minor differences between docs so I think this is no longer feasible.
chelsea-lin
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #432038604