Skip to content

feat: Add CSS styles and page selector to TableWidget #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add CSS styles and page selector to TableWidget #1913

wants to merge 2 commits into from
+205 −70

Conversation

prodonjs
Copy link

@prodonjs prodonjs commented Jul 16, 2025 •
edited
Loading

Screencast

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/406027135

@prodonjs prodonjs requested review from a team as code owners July 16, 2025 21:14
@prodonjs prodonjs requested a review from shobsi July 16, 2025 21:14
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jul 16, 2025
@prodonjs prodonjs changed the title Add CSS styles and page size handling to TableWidget feat: Add CSS styles and page selector to TableWidget Jul 17, 2025
shuoweil
shuoweil reviewed Jul 17, 2025
View reviewed changes
Copy link
Contributor

@shuoweil shuoweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introducing .css file to Bigframes required edit in system files like .pre-commit-config.yaml and owlbot.py

shuoweil
shuoweil reviewed Jul 17, 2025
View reviewed changes
bigframes/display/anywidget.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need comprehensive page size validation and batch management

bigframes/display/table_widget.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need a more robust UI structure:
(1) Creates separate containers for table content and footer with proper CSS classes
(2) Adds row count display showing total rows
(3) Implements page size selector with predefined options [10, 25, 50, 100] and proper selection state
(4) Better organized DOM structure with dedicated containers for pagination and page size controls

bigframes/display/table_widget.css
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need additional build configuration:
(1) Updates .pre-commit-config.yaml to include CSS files in biome-check
(2) Modifies owlbot.py to include CSS files in the package manifest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuoweil shuoweil shuoweil left review comments

@shobsi shobsi Awaiting requested review from shobsi shobsi is a code owner automatically assigned from googleapis/api-bigquery-dataframe

At least 1 approving review is required to merge this pull request.

Assignees

@sycai sycai

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prodonjs @shuoweil @sycai