Skip to content

refactor: sqlglot scalar unit tests expressions #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 18, 2025
Merged

refactor: sqlglot scalar unit tests expressions #1916

merged 4 commits into from
Jul 18, 2025
+202 −115

Conversation

chelsea-lin
Copy link
Contributor

The sqlglot scalar unit tests are being converted to use ArrayValue for operations, since some scalar functions do not have a matching pandas API.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jul 17, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_scalar_tests branch from b95863d to 6ba5882 Compare July 17, 2025 20:15
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jul 17, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_scalar_tests branch 2 times, most recently from 5218581 to 430744e Compare July 17, 2025 20:17
@chelsea-lin chelsea-lin requested review from TrevorBergeron and sycai and removed request for sycai July 17, 2025 20:19
@chelsea-lin chelsea-lin marked this pull request as ready for review July 17, 2025 20:19
@chelsea-lin chelsea-lin requested review from a team as code owners July 17, 2025 20:19
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_scalar_tests branch from 430744e to 9a246e5 Compare July 17, 2025 20:25
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_scalar_tests branch from 9a246e5 to cbcc887 Compare July 17, 2025 20:29
@chelsea-lin chelsea-lin merged commit e5d996c into main Jul 18, 2025
23 of 25 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_scalar_tests branch July 18, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrevorBergeron TrevorBergeron TrevorBergeron approved these changes

Assignees

@GarrettWu GarrettWu

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chelsea-lin @TrevorBergeron @GarrettWu