refactor: provide infrastructure for SQLGlot aggregations compiler #1926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e7a76f3 to
49263e8
Compare
49263e8 to
b771319
Compare
sycai
previously approved these changes
Jul 21, 2025
tests/unit/core/compile/sqlglot/aggregations/test_op_registration.py
Outdated
Show resolved
Hide resolved
sycai
approved these changes
Jul 22, 2025
|
The "test_create_job_configs_labels_log_adaptor_call_method_under_length_limit" failures does not look like to relate this change. Hence, create #1927 to fix this flaky test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes internal issue 431277229🦕