Skip to content

feat: support typed pyarrow.Scalar in assignment #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 23, 2025
Merged

feat: support typed pyarrow.Scalar in assignment #1930

merged 12 commits into from
Jul 23, 2025

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Jul 22, 2025 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Relates to #1928

Similar to internal issue 428999884 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jul 22, 2025
tswast
tswast commented Jul 22, 2025
View reviewed changes
@tswast tswast marked this pull request as ready for review July 22, 2025 21:36
@tswast tswast requested review from a team as code owners July 22, 2025 21:36
@tswast tswast requested a review from Genesis929 July 22, 2025 21:36
tswast
tswast commented Jul 22, 2025
View reviewed changes
@tswast tswast requested review from chelsea-lin and removed request for Genesis929 July 22, 2025 21:53
@tswast tswast assigned chelsea-lin and unassigned liujiashang Jul 22, 2025
@chelsea-lin chelsea-lin mentioned this pull request Jul 22, 2025
Closed
@tswast tswast mentioned this pull request Jul 23, 2025
Closed
1 task
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jul 23, 2025
tswast
tswast commented Jul 23, 2025
View reviewed changes
third_party/bigframes_vendored/ibis/expr/datatypes/value.py Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have also applied this patch upstream: ibis-project/ibis#11483

tswast and others added 8 commits July 23, 2025 12:13
@tswast tswast merged commit cd28e12 into main Jul 23, 2025
19 of 25 checks passed
@tswast tswast deleted the support-pyarrow-scalar branch July 23, 2025 17:54
@release-please release-please bot mentioned this pull request Jul 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

Assignees

@chelsea-lin chelsea-lin

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @chelsea-lin @liujiashang