Skip to content

fix: add license header and correct issues in dbt sample #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2025
Merged

fix: add license header and correct issues in dbt sample #1931

merged 2 commits into from
Jul 25, 2025

Conversation

jialuoo
Copy link
Contributor

@jialuoo jialuoo commented Jul 22, 2025 •
edited
Loading

This follow-up PR addresses the left comments from #1898.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels Jul 22, 2025
@jialuoo jialuoo requested a review from tswast July 23, 2025 00:05
@jialuoo jialuoo marked this pull request as ready for review July 23, 2025 00:06
@jialuoo jialuoo requested review from a team as code owners July 23, 2025 00:06
@jialuoo jialuoo requested a review from gericdong July 23, 2025 00:06
@GarrettWu GarrettWu removed their assignment Jul 24, 2025
@jialuoo jialuoo self-assigned this Jul 25, 2025
@jialuoo jialuoo enabled auto-merge (squash) July 25, 2025 20:02
@jialuoo jialuoo merged commit ab01b0a into main Jul 25, 2025
18 of 25 checks passed
@jialuoo jialuoo deleted the dbt-sample-fix branch July 25, 2025 20:25
@release-please release-please bot mentioned this pull request Jul 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@gericdong gericdong Awaiting requested review from gericdong gericdong is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees

@jialuoo jialuoo

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jialuoo @tswast @GarrettWu