Skip to content

perf: Replace expensive len() call with PandasBatches.total_rows in anywidget TableWidget #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

perf: Replace expensive len() call with PandasBatches.total_rows in anywidget TableWidget #1937

wants to merge 15 commits into from
+256 −72

Conversation

shuoweil
Copy link
Contributor

perf: Replace expensive len() call with PandasBatches.total_rows in anywidget TableWidget

@shuoweil shuoweil self-assigned this Jul 24, 2025
@shuoweil shuoweil requested review from a team as code owners July 24, 2025 23:22
@shuoweil shuoweil requested a review from GarrettWu July 24, 2025 23:22
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jul 24, 2025
@shuoweil shuoweil requested review from tswast and removed request for GarrettWu July 24, 2025 23:23
@shuoweil shuoweil force-pushed the shuowei-anywidget-remove-len-call branch from aee37a7 to 303c4af Compare July 24, 2025 23:23
tswast
tswast reviewed Jul 25, 2025
View reviewed changes
@tswast
Copy link
Collaborator

tswast commented Jul 29, 2025

Please also update the benchmarks to use the total_rows parameter.

@shuoweil shuoweil force-pushed the shuowei-anywidget-remove-len-call branch from fc38cf3 to f643cfb Compare July 30, 2025 03:28
@shuoweil
Copy link
Contributor Author

shuoweil commented Jul 30, 2025 •
edited
Loading

Please also update the benchmarks to use the total_rows parameter.

Let's use a separate PR for this request. #1949

@shuoweil shuoweil requested a review from tswast July 30, 2025 03:29
@shuoweil shuoweil force-pushed the shuowei-anywidget-remove-len-call branch 2 times, most recently from e12c8ff to f8ab27b Compare July 30, 2025 22:07
@shuoweil shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2025
@shuoweil shuoweil force-pushed the shuowei-anywidget-remove-len-call branch from f8ab27b to df85824 Compare July 31, 2025 04:32
tswast
tswast reviewed Jul 31, 2025
View reviewed changes
@shuoweil shuoweil force-pushed the shuowei-anywidget-remove-len-call branch from df85824 to 2756968 Compare August 1, 2025 08:06
@shuoweil shuoweil requested a review from tswast August 1, 2025 08:07
@shuoweil shuoweil force-pushed the shuowei-anywidget-remove-len-call branch 7 times, most recently from 5bc65ce to 26eb25e Compare August 9, 2025 00:18
@shuoweil shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2025
tswast
tswast reviewed Aug 14, 2025
View reviewed changes
@shuoweil shuoweil force-pushed the shuowei-anywidget-remove-len-call branch from 0d6a300 to 00f203e Compare August 14, 2025 21:56
@shuoweil shuoweil requested a review from tswast August 14, 2025 22:13
@shuoweil shuoweil force-pushed the shuowei-anywidget-remove-len-call branch from cc7add6 to 8e9f8ee Compare August 19, 2025 05:57
tswast
tswast reviewed Aug 19, 2025
View reviewed changes
@shuoweil shuoweil force-pushed the shuowei-anywidget-remove-len-call branch from 8e9f8ee to 536345c Compare August 19, 2025 21:11
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Aug 19, 2025
@shuoweil shuoweil requested a review from tswast August 19, 2025 21:27
@shuoweil shuoweil force-pushed the shuowei-anywidget-remove-len-call branch from 79a10b8 to 0caaa52 Compare August 21, 2025 21:07
@shuoweil shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 21, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast Awaiting requested review from tswast

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron

Requested changes must be addressed to merge this pull request.

Assignees

@shuoweil shuoweil

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuoweil @tswast @bigframes-bot